-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat: New node type keys for m&e devices #4485
base: devel
Are you sure you want to change the base?
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4485
# Activate the virtual environment
source test-avd-pr-4485/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/sugetha24/ansible-avd.git@media_node_type_keys#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/sugetha24/ansible-avd.git#/ansible_collections/arista/avd/,media_node_type_keys --force
# Optional: Install AVD examples
cd test-avd-pr-4485
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add these new types to the docs. There is a table of node types and a snip of yaml showing the default values.
"type": "ptp_leaf", | ||
"connected_endpoints": True, | ||
"network_services": { | ||
"l2": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need L2 on all device types? Do you have a design I can look at?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes PTP distribution leafs can also have l2 connected endpoints . Slide 13 here is an example where PTP leaf is also a media_leaf which has connected endpoints which can be a mix of both L2 and/or L3. https://docs.google.com/presentation/d/1XyV6eMJpGsNNP9bxZaxJ25e2VBK96W2rOyHbwZgKanw/edit#slide=id.g1a2c972f82e_0_204
@@ -174,6 +173,39 @@ | |||
"l3": True, | |||
}, | |||
}, | |||
{ | |||
"key": "ptp_leaf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be prefixed with media_
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be okay to leave the media_ so non-media PTP customers can consume it too ?
1b53c75
to
84ecbd6
Compare
84ecbd6
to
c330924
Compare
Quality Gate passedIssues Measures |
Change Summary
Introducing a new default Node type Keys for M&E devices
Related Issue(s)
Fixes #4484
Component(s) name
arista.avd.eos_designs
Proposed changes