Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deal with warnings in zkey.rs #12

Open
oskarth opened this issue Nov 27, 2021 · 0 comments
Open

Deal with warnings in zkey.rs #12

oskarth opened this issue Nov 27, 2021 · 0 comments

Comments

@oskarth
Copy link
Contributor

oskarth commented Nov 27, 2021

Problem

Currently zkey.rs generates a bunch of warnings. Since rust clippy is run as part of the linting CI process (https://github.com/gakonst/ark-circom/blob/master/.github/workflows/ci.yml#L61), these should probably be dealt with.

Details

> cargo clippy
    Checking ark-circom v0.1.0 (/home/oskarth/git/ark-circom)
warning: field is never read: `size`
  --> src/zkey.rs:46:5
   |
46 |     size: usize,
   |     ^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: field is never read: `ftype`
  --> src/zkey.rs:61:5
   |
61 |     ftype: String,
   |     ^^^^^^^^^^^^^

warning: field is never read: `version`
  --> src/zkey.rs:62:5
   |
62 |     version: u32,
   |     ^^^^^^^^^^^^

warning: field is never read: `n8q`
   --> src/zkey.rs:258:5
    |
258 |     n8q: u32,
    |     ^^^^^^^^

warning: field is never read: `q`
   --> src/zkey.rs:259:5
    |
259 |     q: BigInteger256,
    |     ^^^^^^^^^^^^^^^^

warning: field is never read: `n8r`
   --> src/zkey.rs:261:5
    |
261 |     n8r: u32,
    |     ^^^^^^^^

warning: field is never read: `r`
   --> src/zkey.rs:262:5
    |
262 |     r: BigInteger256,
    |     ^^^^^^^^^^^^^^^^

warning: field is never read: `power`
   --> src/zkey.rs:268:5
    |
268 |     power: u32,
    |     ^^^^^^^^^^

warning: `ark-circom` (lib) generated 8 warnings
gakonst pushed a commit that referenced this issue Dec 22, 2021
* circom2 proof generation

* fix fmt and test

* fix clippy and format dependency

* make clippy happy (circom2 changes)

* make clippy happy (#12)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@oskarth and others