Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Space missing from behind the 'staged' symbol in default config #24

Closed
atleta opened this issue Jun 5, 2020 · 2 comments · Fixed by #25
Closed

Space missing from behind the 'staged' symbol in default config #24

atleta opened this issue Jun 5, 2020 · 2 comments · Fixed by #25

Comments

@atleta
Copy link

atleta commented Jun 5, 2020

Hi,

Minor issue, but a space is missing from behind the ●/staged symbol in the default config in tmux/formatter.go (https://github.com/arl/gitmux/blob/master/format/tmux/formater.go#L55) and it makes that part of the display illegible (at least with the default fixed font on ubuntu). Indeed, I haven't realized what that blob could be until I got myself to look into gitmux config to fix the colors.

I see there's a space after all the other symbols, so this must be accidental or not causing a problem with the font you are using.

Expected Behavior

Selection_999(302)

Actual Behavior

Selection_999(303)

Specifications

  • OS: Ubuntu 20.04
  • gitmux version: 0.3.2 and 0.5.0
  • tmux version: tmux -V
arl added a commit that referenced this issue Jun 7, 2020
@arl
format/tmux: add missing spaces after symbols
1053e28 
The 'staged' and 'untracked' symbols are both missing a trailing
space in the default configuration. With some fixed fonts (for
instance the stock Ubuntu font) this makes difficult to discern
between the symbol and the number following it.

Fixes #24
@arl arl mentioned this issue Jun 7, 2020
Merged
@arl
Copy link
Owner

arl commented Jun 7, 2020

@atleta thanks for reporting, that is now fixed on master.

@arl arl closed this as completed in #25 Jun 7, 2020
arl added a commit that referenced this issue Jun 7, 2020
@arl
format/tmux: add missing spaces after symbols (#25)
5ef17f1 
The 'staged' and 'untracked' symbols are both missing a trailing
space in the default configuration. With some fixed fonts (for
instance the stock Ubuntu font) this makes difficult to discern
between the symbol and the number following it.

Fixes #24
@arl
Copy link
Owner

arl commented Jun 7, 2020

@atleta FYI this is fixed in latest release

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

format/tmux: add missing spaces after symbols arl/gitmux
2 participants
@arl @atleta