Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: option to add space between behind & ahead upstream #111

Closed

Conversation

marcoSven
Copy link
Contributor

Purpose

Adding a space between behind & ahead upstream is currently not possible

Approach

Adding an option to add a single space

Before
Screenshot 2024-04-15 at 15 46 38

After
Screenshot 2024-04-15 at 15 47 17

Signed-off-by: marcoSven <me@marcosven.com>
@arl
Copy link
Owner

arl commented Apr 16, 2024

Can't you obtain the same outcome by adding a space in front of the behind symbols in your gitmux file?

@marcoSven
Copy link
Contributor Author

We only want to add a space between ahead and behind count.

Adding a space in front would add an undesired extra space.

"Ahead""\sBehind"

"\sBehind" <- undesired space

Copy link
Owner

@arl arl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this.

Please add 2 unit tests:

  • where divergence_space=true and swap_divergence=false
  • where divergence_space=true and swap_divergence=true

@marcoSven marcoSven force-pushed the feature/space-between-divergence branch 4 times, most recently from e588ab1 to 5902577 Compare April 16, 2024 20:58
Signed-off-by: marcoSven <me@marcosven.com>
@marcoSven marcoSven force-pushed the feature/space-between-divergence branch from 5902577 to 33eb0cf Compare April 16, 2024 21:00
@marcoSven marcoSven requested a review from arl April 16, 2024 21:02
Copy link
Owner

@arl arl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay between review.
There's just a last thing and we're good
Thank you.

@@ -83,3 +83,4 @@ tmux:
hide_clean: false
# Swaps order of behind & ahead upstream counts - "↓·1↑·1" -> "↑·1↓·1"
swap_divergence: false
divergence_space: false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This misses a doc string. You can use the same one as the readme.
The content of this file is output for gitmux -printfg

@arl
Copy link
Owner

arl commented Jun 9, 2024

@marcoSven I'm closing this in favor of #117 which got your code and some additional commits I've made on top of them.

thank you!

@arl arl closed this Jun 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants