Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: only render if hideClean is false and there are stashes #93

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix: only render if hideClean is false and there are stashes #93

merged 2 commits into from
Mar 22, 2023

Conversation

joshmedeski
Copy link
Contributor

Purpose

When HideClean is enable, a component would still get rendered because of the clear fix join.

Approach

Check if the stash or clean components have been defined before cleaning and joining them.

arl
arl approved these changes Mar 22, 2023
View reviewed changes
Copy link
Owner

@arl arl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
That makes sense. And solves your issue in a nice way as well. Great

@arl arl merged commit 25d89f7 into arl:main Mar 22, 2023
@arl
Copy link
Owner

arl commented Mar 22, 2023

@joshmedeski I've just tagged a new release with this -> v0.10.1

@joshmedeski joshmedeski deleted the fix-hide-clean-render branch March 22, 2023 15:43
@arl arl mentioned this pull request Mar 22, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@arl arl arl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmedeski @arl