Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert commit that breaks compilation #7804

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Revert commit that breaks compilation #7804

merged 1 commit into from
Feb 8, 2025

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Feb 8, 2025 •
edited
Loading

Description

There were upstream changes that are related to board Rockpi S0, rev. 1.2 which breaks our patch. This needs deeper analysis and testing, so lets revert to known situation so compilation from main on rockchip64 moves on.

@brentr Check when you can and remove this revert patch once fixed.

How Has This Been Tested?

  • CI test

Checklist:

  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added Build Executing build train (permission needed) 02 Milestone: First quarter release labels Feb 8, 2025
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Feb 8, 2025
@igorpecovnik igorpecovnik added Build Executing build train (permission needed) and removed Build Executing build train (permission needed) labels Feb 8, 2025
@igorpecovnik
Revert commit that breaks compilation
bbdc419 
This needs deeper anlysis and testing, so lets revert to known situation
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Feb 8, 2025
@igorpecovnik igorpecovnik merged commit 2087a8b into main Feb 8, 2025
51 checks passed
@igorpecovnik igorpecovnik deleted the revert-rockpi0 branch February 8, 2025 18:38
@brentr
Copy link
Collaborator

brentr commented Feb 11, 2025

main branch current kernel still works.
Tested RockPI-S and Rock-S0.
Not a full test, but verified they boot and WiFi works.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
02 Milestone: First quarter release Build Executing build train (permission needed) Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @brentr