module, bpf: Store BTF base pointer in struct module #328
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as this will allow split BTF modules with a base BTF representation (rather than the full vmlinux BTF at time of BTF encoding) to resolve their references to kernel types in a way that is more resilient to small changes in kernel types. This will allow modules that are not built every time the kernel is to provide more resilient BTF, rather than have it invalidated every time BTF ids for core kernel types change. Fields are ordered to avoid holes in struct module. Signed-off-by: Alan Maguire <alan.maguire@oracle.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> Acked-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/bpf/20240620091733.1967885-3-alan.maguire@oracle.com
rpardini
approved these changes
Feb 7, 2025
|
Confirmed, DKMS modules fixed with this. Super thanks once again @amazingfate |
|
Just ignore it. Update armbian/build and it won't appear anymore.
$ sudo dmesg | grep "failed to validate module"
[ 9.195032] failed to validate module [rockchip_cpuinfo] BTF: -22
[ 11.050398] failed to validate module [ipv6] BTF: -22
[ 11.128316] failed to validate module [ip_tables] BTF: -22
[ 11.356589] failed to validate module [ipv6] BTF: -22
[ 11.787741] failed to validate module [nfnetlink] BTF: -22
[ 11.950656] failed to validate module [dm_mod] BTF: -22
[ 11.979497] failed to validate module [fuse] BTF: -22
[ 12.029522] failed to validate module [sch_fq_codel] BTF: -22
[ 12.149638] failed to validate module [binfmt_misc] BTF: -22
[ 12.170584] failed to validate module [uio] BTF: -22
[ 12.185193] failed to validate module [zsmalloc] BTF: -22
[ 12.296925] failed to validate module [rockchip_cpuinfo] BTF: -22
[ 12.299377] failed to validate module [gpu_sched] BTF: -22
[ 12.299395] failed to validate module [uio] BTF: -22
[ 12.355997] failed to validate module [dm_mod] BTF: -22
[ 12.357748] failed to validate module [fuse] BTF: -22
[ 12.456602] failed to validate module [uio] BTF: -22
[ 12.510774] failed to validate module [binfmt_misc] BTF: -22
[ 12.532820] failed to validate module [uio] BTF: -22
[ 12.593696] failed to validate module [uio] BTF: -22
[ 12.680587] failed to validate module [rockchip_cpuinfo] BTF: -22
[ 12.720718] failed to validate module [rk805_pwrkey] BTF: -22
[ 12.721634] failed to validate module [pwm_fan] BTF: -22
[ 12.765257] failed to validate module [uio] BTF: -22
[ 12.866219] failed to validate module [zsmalloc] BTF: -22
[ 12.866861] failed to validate module [uio] BTF: -22
[ 12.868720] failed to validate module [dm_mod] BTF: -22
[ 12.869499] failed to validate module [fuse] BTF: -22
[ 13.012933] failed to validate module [binfmt_misc] BTF: -22
[ 13.141378] failed to validate module [ipv6] BTF: -22
[ 13.228125] failed to validate module [ipv6] BTF: -22
[ 13.302786] failed to validate module [ipv6] BTF: -22
[ 13.540398] failed to validate module [ipv6] BTF: -22
[ 14.464063] failed to validate module [ipv6] BTF: -22
[ 15.056623] failed to validate module [ipv6] BTF: -22
[ 15.143014] failed to validate module [ipv6] BTF: -22
[ 30.138352] failed to validate module [ipv6] BTF: -22
[ 30.254243] failed to validate module [ipv6] BTF: -22
[ 33.881959] failed to validate module [ipv6] BTF: -22
[ 36.438635] failed to validate module [ipv6] BTF: -22
[ 76.272237] failed to validate module [ipv6] BTF: -22
[ 94.872397] failed to validate module [ipv6] BTF: -22
[ 107.426049] failed to validate module [ipv6] BTF: -22
[ 135.470392] failed to validate module [ipv6] BTF: -22
[ 145.174831] failed to validate module [ipv6] BTF: -22
[ 159.117154] failed to validate module [ipv6] BTF: -22
[ 166.355365] failed to validate module [ipv6] BTF: -22 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have backported torvalds/linux@f34d086 to fix dkms module load issue for rkr4.1 kernel, but after updating to rkr5 it issue comes again.
I have to backport this commit when I'm investigating the issue: armbian/build#7629 (comment).