Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add dummy middleware that removes ESI tags from the DOM #15

Closed
wants to merge 4 commits into from

Conversation

crccheck
Copy link
Member

Closes #14

Functionality is complete, but missing changes to support.

If 'armstrong.esi.middleware.DummyEsiMiddleware' is in your MIDDLEWARE_CLASSES, esis will be rendered as comments instead of esi tags:

    <!--esi:include src="/esi/accounts/analytics/" /-->

instead of the rendered esi or the original esi tag:

    <esi:include src="/esi/accounts/analytics/" />

RFC

The thought presently occurs that perhaps this should be NullEsiMiddleware instead of DummyEsiMiddleware.

TODO

@crccheck
Copy link
Member Author

bump. issue #14 is driving me crazy.

@crccheck crccheck closed this Jan 27, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raw esi tag creates broken html
1 participant