feat: introduces jakarta servlet 6.0 protocol module #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir V. Bychkov <github@bychkov.name>
.../servlet-jakarta/src/main/java/org/jboss/arquillian/protocol/servlet5/Servlet5Extension.java
Outdated
Show resolved
Hide resolved
Class renamed to avoid ambiguity
Now this new protocol (Servlet 6.0) mainly duplicates already existed "Servlet 5.0", also where is no necessity in additional tests (in addition to Servlet 5.0). May be in future this new protocol becomes more its own functionality and this makes tests useful/necessary. |
chengfang
approved these changes
May 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
As a part of Adaptation to Jakarta EE 10 this PR adds new protocol - Servlet 6.0