Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Failure of parameterized test is not reported as a failure #505

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Failure of parameterized test is not reported as a failure #505

merged 1 commit into from
Nov 7, 2023

Conversation

TomasHofman
Copy link
Contributor

Fixes #504

Short description of what this resolves:

Fixes an issue where parameterized tests are reported as passed, even if they failed.

Changes proposed in this pull request:

  • Call ExceptionUtils::throwAsUncheckedException() in the ArquillianExtension#interceptTestTemplateMethod() method even if the invocation is RunAsClient.

For a test case:

  • Added dependency on junit-jupiter-params JAR, to make the @ParameterizedTest annotation available.
  • Added a test case.

@starksm64 starksm64 self-assigned this Nov 7, 2023
@starksm64 starksm64 merged commit f9ba546 into arquillian:master Nov 7, 2023
@starksm64
Copy link
Member

Thanks for the report and fix, which has been merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@starksm64 starksm64 starksm64 approved these changes

Assignees

@starksm64 starksm64

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Junit 5 @ParameterizedTest incorrect reporting when used with Arquillian
2 participants
@TomasHofman @starksm64