Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Part 1 of the jakarta package dependency refactoring, #516 #517

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

starksm64
Copy link
Member

Short description of what this resolves:

Part 1 removes the modules with jakarta.* package dependencies, Part 2 will restore those modules in the arquillian-jakarta repo

Changes proposed in this pull request:

  • Remove modules from core that depend on the jakarta.* packages

Fixes #
#516

Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64 starksm64 changed the title Part 1 of thjakarta package dependency refactoring, #516 Part 1 of the jakarta package dependency refactoring, #516 Nov 16, 2023
@starksm64 starksm64 merged commit 00954a8 into arquillian:master Nov 17, 2023
@starksm64
Copy link
Member Author

starksm64 commented Nov 17, 2023

@jamezp I have run all of the tests in the wildfly/wildfly-arquillian repo against the current 1.7.3.Final-SNAPSHOT and the 1.8.0.Final-SNAPSHOT local builds and it passes. I was just going to put out the 1.8.0.Final releases of core and jakarta at this point.

@jamezp
Copy link
Collaborator

jamezp commented Nov 17, 2023

Ah, perfect! Thank you @starksm64. Once they're out I can get them integrated into the main branch of wildfly-arquillian.

@starksm64
Copy link
Member Author

@jamezp See wildfly/wildfly-arquillian#390.
I basically had to do a PR to validate all was working because after I did the 1.8.0.Final releases I was seeing dependency constraint violations due to mismatches in jakarta api version. There still is a problem with cdi 4.0.1 referencing an older annotations 2.1.0, and so I had to add an exclude for that in the cdi import.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants