Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[611] Add an @ArquillianTest annotation for simply extending the Arqu… #612

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jamezp
Copy link
Collaborator

@jamezp jamezp commented Aug 13, 2024

…illianExtension on tests. Replace the JUnit 5 integration tests annotations.

resolves #611

Note this is a nice to have and if anyone thinks it's not all that useful, it can simply closed and rejected.

…illianExtension on tests. Replace the JUnit 5 integration tests annotations.

Signed-off-by: James R. Perkins <jperkins@redhat.com>
Copy link
Collaborator

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, given that the JUnit 5 @ExtendWith is repeatable, I think this is fine. I am still on the fence whether the benefits are worth the effort supporting an extra annotation.

@jamezp
Copy link
Collaborator Author

jamezp commented Aug 13, 2024

IIUC, given that the JUnit 5 @ExtendWith is repeatable, I think this is fine. I am still on the fence whether the benefits are worth the effort supporting an extra annotation.

Yes, it's repeatable. The main advantage is we could extend it with parameters. For example, we could potentially add a manualMode option which would indicate the test is a manual mode test. Or if we end up with some other extension that doesn't fit into the ArquillianExtension, we simply add it to the annotation and users don't need to change anything.

@starksm64 starksm64 merged commit 30137d4 into arquillian:main Aug 13, 2024
16 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a simple annotation for enabling Arquillian on JUnit 5
3 participants