Stop persisting search icon's 'wash' state across sections (AIC-592) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam33rdhakal
approved these changes
Oct 29, 2018
sam33rdhakal
deleted the
pc-stop-persisting-search-icon-wash-state-AIC-592
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a bit of background, we use the same immutable
Drawableobject whenever we load the resource id. This is usually just a nice memory-saving benefit of using default Resource-loading logic.In the case of the search icons' background (defined in style
@style/Search.PrimaryScreen, known formally as the 'wash'), this behavior is at the cause of some minor inconsistency. The wash's transparency should reflect its host fragment's scroll state.