Account for weightless tours (AIC-597) #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam33rdhakal
previously approved these changes
Oct 30, 2018
Cliabhach
force-pushed
the
pc-account-for-weightless-tours-AIC-597
branch
from
35bbef5 to
e0087df
Compare
I think something in the Moshi 1.7.0 upgrade broke this....on the plus side, the fix I include here is pretty concise.
Cliabhach
force-pushed
the
pc-account-for-weightless-tours-AIC-597
branch
from
e0087df to
f53dd2a
Compare
|
Oh, I see. I broke one of the tests with that update to |
|
And it did! @sam33rdhakal would you re-approve this? |
sam33rdhakal
approved these changes
Oct 31, 2018
|
We'll need to make use of |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ArticTour objects may not come with a valid
weightproperty. Until we derive a more generic solution for unexpected data formation, this will prevent issues at application startup caused by not detecting this property.