Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes object marker click issues (AIC-605) #323

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Conversation

sam33rdhakal
Copy link
Contributor

InfoWindowAdapter was implemented incorrectly. Hidden InfoWindow was intercepting the clicks.
Don't know why view initialized as View(requireContext()) taking large space. When it is replaced with

TextView(requireContext()).apply {
                        text = " "
                    }

it worked fine.

@sam33rdhakal sam33rdhakal force-pushed the map_object_marker_issue branch from b5d1847 to 0a18182 Compare November 2, 2018 02:01
@Cliabhach
Copy link
Contributor

Perhaps we should set a maximum text length of e.g. 1 too?

Copy link
Contributor

@Cliabhach Cliabhach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to mark it as unimportant for accessibility at some point in the future. For now, this'll do.

@Cliabhach Cliabhach changed the title Fixes object marker click issues Fixes object marker click issues (AIC-605) Nov 2, 2018
@Cliabhach Cliabhach merged commit 3f1fda6 into dev Nov 2, 2018
@Cliabhach Cliabhach deleted the map_object_marker_issue branch November 2, 2018 15:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants