-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support of forks and authorization token #5
Conversation
Oh in addition I was in hurry and it is late here already so typos may occur. I will check them tomorrow) |
@arthuro555 Hi! Is there a chance that you can review this PR? |
Sorry for my lack of reactivity, I am kind of hesitant to add this. I feel like for forks, it is not a good idea to use this. Currently, some of the GDevelop code is embedded in the repository, and needs to be updated with GDevelop updates. As such, if GDevelop diverges from the fork in these aspects, this will break on forks. Generally, my vision as well was to remove the dynamic fetching of GDevelop runtime code, instead opting for obtaining this GDevelop code from the GDevelop repository at build time, and to release a version of the package on NPM with an embedded GDevelop runtime & GDCore for the latest versions of GDevelop, re-releasing a new package for every GDevelop update. My recommendation would be instead to fork this repository, replace references to upstream GDevelop with your own repository, and to publish your own fork of the package on npm for usage in your projects. |
Closing this now, since I have opened the PR for V2.
|
Hi and sorry that I barge in like this)
For the last few months I have been actively working with GDevelop and its improvement and I found your tool very convenient.
This PR adds two main features
octokit request api
to increase API limit rateI added
user
option to redirect to forks. Loading ofRuntime
sources is pretty easy task in this case but storage oflibGD
assets is a more specific thing. E.g. in my case I attach them to release. I added few options to improve flexibilityI want to say that I did not break old API structure
P.S. During my changes code grew so much so I allowed myself to split it by different files. Hope that is ok)
Here is exporter PR arthuro555/gdexporter#9