Update cargo install instructions to declare 'trunk' branch #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also rust-lang/cargo#3517. Breakage caused by artichoke/artichoke#961.
lopopolo
added
A-build
Default to trunk if ARTICHOKE_NIGHTLY_VER is not set via the docker command line.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
Dockerfiles to useARTICHOKE_NIGHTLY_VERif set to anything other thanlatestto install a specific git revision. This matches the behavior of artichoke/nightly where the git revision is resolved at workflow-time and propagated through the installation workflow. This change ensures that the images tagged with a git SHA match the built artichoke they contain.See also rust-lang/cargo#3517.
Breakage caused by artichoke/artichoke#961.