Addresses Andy's comments

articulate · Nov 12, 2019 · a11067a · a11067a
1 parent 46aa3a6
commit a11067a
Show file tree

Hide file tree

Showing 7 changed files with 59 additions and 5 deletions.
diff --git a/examples/okta_app_basic_auth/README.md b/examples/okta_app_basic_auth/README.md
@@ -1,4 +1,4 @@
-# okta_app_bookmark
+# okta_app_basic_auth
 
 Represents an Okta Basic Auth App. [See Okta documentation for more details](https://developer.okta.com/docs/reference/api/apps/#add-basic-authentication-application).
 

diff --git a/examples/okta_app_basic_auth/basic_updated.tf b/examples/okta_app_basic_auth/basic_updated.tf
@@ -19,4 +19,6 @@ resource "okta_app_basic_auth" "test" {
     id       = "${okta_user.user.id}"
     username = "${okta_user.user.email}"
   }
+
+  groups = ["${okta_group.group.id}"]
 }
diff --git a/examples/okta_app_bookmark/basic_updated.tf b/examples/okta_app_bookmark/basic_updated.tf
@@ -18,4 +18,6 @@ resource "okta_app_bookmark" "test" {
     id       = "${okta_user.user.id}"
     username = "${okta_user.user.email}"
   }
+
+  groups = ["${okta_group.group.id}"]
 }
diff --git a/okta/provider.go b/okta/provider.go
@@ -162,7 +162,6 @@ func Provider() terraform.ResourceProvider {
 			"okta_saml_idp_signing_key":      deprecateIncorrectNaming(resourceIdpSigningKey(), idpSamlKey),
 			"okta_social_idp":                deprecateIncorrectNaming(resourceIdpSocial(), idpSocial),
 			"okta_bookmark_app":              deprecateIncorrectNaming(resourceAppBookmark(), appBookmark),
-			"okta_basic_auth_app":            deprecateIncorrectNaming(resourceAppBasicAuth(), appBasicAuth),
 			"okta_saml_app":                  deprecateIncorrectNaming(resourceAppSaml(), appSaml),
 			"okta_oauth_app":                 deprecateIncorrectNaming(resourceAppOAuth(), appOAuth),
 			"okta_oauth_app_redirect_uri":    deprecateIncorrectNaming(resourceAppOAuthRedirectUri(), appOAuthRedirectUri),

diff --git a/okta/resource_okta_app_basic_auth.go b/okta/resource_okta_app_basic_auth.go
@@ -8,9 +8,6 @@ import (
 
 func resourceAppBasicAuth() *schema.Resource {
 	return &schema.Resource{
-		CustomizeDiff: func(d *schema.ResourceDiff, v interface{}) error {
-			return nil
-		},
 		Create: resourceAppBasicAuthCreate,
 		Read:   resourceAppBasicAuthRead,
 		Update: resourceAppBasicAuthUpdate,

diff --git a/website/docs/r/app_basic_auth.html.markdown b/website/docs/r/app_basic_auth.html.markdown
@@ -0,0 +1,51 @@
+---
+layout: "okta"
+page_title: "Okta: okta_app_basic_auth"
+sidebar_current: "docs-okta-resource-app-basic-auth"
+description: |-
+  Creates a Basic Auth Application.
+---
+
+# okta_app_basic_auth
+
+Creates a Bsaic Auth Application.
+
+This resource allows you to create and configure a Basic Auth Application.
+
+## Example Usage
+
+```hcl
+resource "okta_app_basic_auth" "example" {
+  label    = "Example"
+  url      = "https://example.com/#.html"
+  auth_url = "https://example.com/auth.html"
+}
+```
+
+## Argument Reference
+
+The following arguments are supported:
+
+* `label` - (Required) The Application's display name.
+
+* `url` - (Optional) The URL of the sign-in page for this app.
+
+* `auth_url` - (Optional) The URL of the authenticating site for this app.
+
+## Attributes Reference
+
+* `id` - ID of the Application.
+
+* `label` - The Application's display name.
+
+* `url` - The URL of the sign-in page for basic auth app.
+
+* `auth_url` - The URL of the authenticating site for basic auth app.
+
+## Import
+
+A Basic Auth App can be imported via the Okta ID.
+
+```
+$ terraform import okta_app_basic_auth.example <app id>
+```
diff --git a/website/okta.erb b/website/okta.erb
@@ -61,6 +61,9 @@
           <li<%= sidebar_current("docs-okta-resource-app-bookmark") %>>
             <a href="/docs/providers/okta/r/app_bookmark.html">okta_app_bookmark</a>
           </li>
+          <li<%= sidebar_current("docs-okta-resource-app-basic-auth") %>>
+            <a href="/docs/providers/okta/r/app_basic_auth.html">okta_app_basic_auth</a>
+          </li>
           <li<%= sidebar_current("docs-okta-resource-app-group-assignment") %>>
             <a href="/docs/providers/okta/r/app_group_assignment.html">okta_app_group_assignment</a>
           </li>