This repository has been archived by the owner on Jun 14, 2021. It is now read-only.
Hashicorp Review -> #269 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quantumew
commented
Sep 4, 2019
•
quantumew
commented
- Fix file names for all resources and data sources
- Commit vendor directory
- Fix two tests that only work in our test tenant. Missing dependencies.
- Makefile -> GNUmakefile and copied the contents of the NULL provider makefile
- Fix linting errors
quantumew
force-pushed
the
chore/commit-dependencies
branch
from
45592fa to
a3baea2
Compare
quantumew
changed the title
quantumew
force-pushed
the
chore/commit-dependencies
branch
4 times, most recently
from
15a00c0 to
777326e
Compare
* Fix file names for all resources and data sources * Commit vendor directory * Fix two tests that only work in our test tenant. Missing dependencies. * Makefile -> GNUmakefile and copied the contents of the NULL provider makefile Update travis file to match standard provider travis file Remove cookie script Go 1.11 Update travis Fixing linting errors, there are a lot Fix linting errors, add missing CheckDestroy Fix some more linting errors Vet step Git did not recognize the file move Install golang lint as documented Fixing some tests I broke Install tf provier linter via brew Cannot brew install lol Vendor tools Vendoring Install tfprovider lint with vendoring Copy over example from another provider, committing before prunning down Add basis for website docs
quantumew
force-pushed
the
chore/commit-dependencies
branch
from
a5381fb to
e118071
Compare
|
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.