Skip to content
This repository has been archived by the owner on Jun 14, 2021. It is now read-only.

Fixes profile master not being set on oidc idp #273

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Fixes profile master not being set on oidc idp #273

merged 2 commits into from
Sep 9, 2019

Conversation

jlew
Copy link
Contributor

@jlew jlew commented Sep 9, 2019

No description provided.

okta/idp.go Outdated
@@ -254,6 +254,7 @@ func getIdentityProviderExists(idp sdk.IdentityProvider) schema.ExistsFunc {
func NewIdpProvisioning(d *schema.ResourceData) *sdk.IDPProvisioning {
return &sdk.IDPProvisioning{
Action: d.Get("provisioning_action").(string),
ProfileMaster: d.Get( "profile_master").(bool),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run make fmt and commit that? Then I think we are g2g on this. Thanks!

@quantumew quantumew self-requested a review September 9, 2019 17:56
Copy link
Contributor

@quantumew quantumew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Running ACC tests now. Will post and merge shortly.

@quantumew
Copy link
Contributor

Screen Shot 2019-09-09 at 1 56 30 PM

@quantumew quantumew merged commit eba18eb into articulate:master Sep 9, 2019
@jlew jlew deleted the fixProfileMaster branch September 9, 2019 18:57
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants