Suppress "this-escape" warnings from generated encoders and decoders #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coders, required for them to compile without warnings in JDK21
|
any objections to this? |
|
hi - could you please suggest a dictionary so we can reproduce this warning? |
|
I've attached the most minimal fix dictionary I could create that reproduces - just one application message with one field. This yields a warning on HeaderEncoder as a result of the constructor, which calls beginStringAsCopy(), which is an instance method - not permitted (without generating a this-escape warning) under JDK21. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #494
This is the simplest, least intrusive change to allow generated decoders to be built under JDK21 without warnings.