Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

S3 credentials should be optional #501

Merged
merged 1 commit into from
Apr 26, 2023
Merged

S3 credentials should be optional #501

merged 1 commit into from
Apr 26, 2023

Conversation

dgarus
Copy link
Contributor

@dgarus dgarus commented Apr 26, 2023

Close artipie/artipie#1281

  • credentials are made optional for S3 storage factory; added test;
  • added using S3 storage factory to get a storage instance in tests.

@dgarus dgarus requested a review from olenagerasimova April 26, 2023 12:34
Copy link
Member

@olenagerasimova olenagerasimova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgarus thanks, also, I think, we need to update wiki by specifying that credentials in s3 config are optional and can be set in env variables.
And, as Config interface was changed, http has to be updated and this new method should be implemented.

@dgarus
Copy link
Contributor Author

dgarus commented Apr 26, 2023

@dgarus thanks, also, I think, we need to update wiki by specifying that credentials in s3 config are optional and can be set in env variables. And, as Config interface was changed, http has to be updated and this new method should be implemented.

Yes, good point.
Thanks

@dgarus dgarus merged commit 72cf14c into artipie:master Apr 26, 2023
@dgarus dgarus deleted the 1281 branch April 26, 2023 14:01
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 credentials should be optional
2 participants