disable deep link on reset password #36
Conversation
| @@ -51,6 +52,7 @@ | |||
| "NOT *L3NpZ25f*", | |||
| "NOT *L3VzZXJzL2F1dGgvZmFjZWJvb2svY2FsbGJhY2s=*", | |||
| "NOT *L2lkZW50aXR5LXZlcmlmaWNhdGlv*", | |||
| "NOT *L3Jlc2V0X3Bhc3N3b3Jk*", | |||
There was a problem hiding this comment.
this came after running yarn build
There was a problem hiding this comment.
Sailthru encodes links in their deep links so this will be the change-password link with Sailthru's encoding, although probably not sending any links to reset password
There was a problem hiding this comment.
Thanks for explaining 🙇♂️
|
I will merge this since it's a small adjustment that we discussed already 🙇♂️ |
|
Artsy-wwwify artsy/artsy-wwwify#71 |
| @@ -36,6 +36,7 @@ | |||
| "NOT /click/*/aHR0cHM6Ly9hcHAuYWRqdXN0LmNv*", | |||
| "NOT /users/auth/facebook/callback*", | |||
| "NOT /identity-verification*", | |||
| "NOT /reset_password", | |||
| "NOT *L2FydGljbGVz*", | |||
There was a problem hiding this comment.
I think we probably also want /forgot and /change-password here and possibly others, working on seeing if I can find a list
There was a problem hiding this comment.
That would be great, I will add an item about this to the practice as well
There was a problem hiding this comment.
Here is it, please feel free to extend it: https://www.notion.so/artsy/Mobile-Practice-ecc07763bfd04a848c74107dde3ec6dc#863ed7100327448faffbe6c5ac7d783c
There was a problem hiding this comment.
That looks complete, asked the dev channel and it looks like those are the only other 2 👍
There was a problem hiding this comment.
Cool then, I will add them now and merge
|
Force artsy/force#7117 |
|
🚀 PR was released in |
We have users getting the app open when pressing on the reset password link on mail. Instead, we want the link to open the browser.