Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: update docs to reflect up to date state #44

Merged
merged 1 commit into from
Nov 3, 2021
Merged

chore: update docs to reflect up to date state #44

merged 1 commit into from
Nov 3, 2021

Conversation

MounirDhahri
Copy link
Member

Description:

  • Since we are no longer using Sailthru, I figured out it makes sense to update the docs to reflect that.
  • We have a build script that encodes the paths added to the web-association file in base64 and extends them there. I think this is no longer needed since Braze are not specifying that in their docs. cc @jonallured
  • I also added an example PR on how to exclude paths in the future

@artsy-peril artsy-peril bot added the Version: Minor Increment the minor version when merged label Nov 3, 2021
@MounirDhahri MounirDhahri requested a review from lordkiz November 3, 2021 09:26
jonallured
jonallured approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@jonallured jonallured left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

brainbicycle
brainbicycle approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@brainbicycle brainbicycle merged commit a55b4b9 into master Nov 3, 2021
@brainbicycle brainbicycle deleted the MounirDhahri/update-docs branch November 3, 2021 16:43
@artsyit
Copy link
Contributor

artsyit commented Nov 3, 2021

🚀 PR was released in v1.2.0 🚀

@artsyit artsyit added the released This issue/pull request has been released. label Nov 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jonallured jonallured jonallured approved these changes

@brainbicycle brainbicycle brainbicycle approved these changes

@lordkiz lordkiz Awaiting requested review from lordkiz

Assignees

@brainbicycle brainbicycle

Labels
released This issue/pull request has been released. Version: Minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MounirDhahri @artsyit @jonallured @brainbicycle