Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sanitize error system #1432

Merged
merged 618 commits into from
Mar 15, 2024
Merged

Sanitize error system #1432

merged 618 commits into from
Mar 15, 2024

Conversation

drkameleon
Copy link
Collaborator

@drkameleon drkameleon commented Dec 28, 2023

Description

Right now, the errors produced are quite messy, or incomplete, or not consistently-presented.

At the same time, we have new Error & ErrorKind values.

The two system should - ideally - be merged into one. Or at least that's what we'll attempt here.

Let's go! 🚀


Type of change

  • Code cleanup
  • Enhancement (implementation update, or general performance enhancements)

@drkameleon drkameleon added enhancement New feature or request vm Issues related to the Virtual Machine implementation error handling Issues related to Error handling experimental Experimental PRs (may be completely abandoned; or maybe not...) labels Dec 28, 2023
@github-actions github-actions bot removed vm Issues related to the Virtual Machine implementation error handling Issues related to Error handling labels Dec 28, 2023
@drkameleon drkameleon changed the title EXPERIMENT: Sanitize error system Sanitize error system Jan 4, 2024
@drkameleon drkameleon removed the experimental Experimental PRs (may be completely abandoned; or maybe not...) label Jan 4, 2024
@github-actions github-actions bot added vm Issues related to the Virtual Machine implementation error handling Issues related to Error handling values Issues related to the core Value type library Issues related to the standard library unit-test Unit tests parser Issues related to the evaluator (src/vm/parse.nim) helpers Issues related to Helper modules labels Feb 5, 2024
@github-actions github-actions bot added the command line Issues related to Arturo's command-line and options label Feb 9, 2024
@github-actions github-actions bot added ui Issues related to the UI execution Issues related to the executor (src/vm/exec.nim) labels Feb 10, 2024
@github-actions github-actions bot added workflows Issues related to GitHub workflows, building, releases, etc ci CI-related issues labels Mar 14, 2024
@drkameleon
Copy link
Collaborator Author

The PR is not 100% complete - but let's say... it's "complete enough".

Many of the original goals have been completed and the whole error system is practically brand new. Now, do I like every single error message? Nope, and that's why I'll follow with different PRs that are going to address the pending issues.

Also, there are different errors that are (still) not getting caught or properly reported, etc. But... all in due time! 😉


That having been said...

Ready to merge! 🚀

@drkameleon drkameleon merged commit 4bed454 into master Mar 15, 2024
14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ast Issues related to the intermediate AST representation ci CI-related issues command line Issues related to Arturo's command-line and options documentation Improvements or additions to documentation enhancement New feature or request error handling Issues related to Error handling evaluator Issues related to the evaluator (src/vm/eval.nim) execution Issues related to the executor (src/vm/exec.nim) helpers Issues related to Helper modules library Issues related to the standard library parser Issues related to the evaluator (src/vm/parse.nim) repl Issues related to the REPL rosetta code Issues and PRs related to Rosetta Code snippets ui Issues related to the UI unit-test Unit tests values Issues related to the core Value type vm Issues related to the Virtual Machine implementation workflows Issues related to GitHub workflows, building, releases, etc
Projects
1 participant