Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[EXPERIMENT] linenoise (antirez/linenoise + msteveb/linenoise) #1742

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

[EXPERIMENT] linenoise (antirez/linenoise + msteveb/linenoise) #1742

wants to merge 9 commits into from

Conversation

Eloitor
Copy link
Contributor

@Eloitor Eloitor commented Sep 26, 2024

Description

Support UTF-8 with linenoise

Fixes # (issue/s)

Type of change

  • Code cleanup
  • Unit tests (added or updated unit-tests)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (implementation update, or general performance enhancements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (documentation-related additions)

@drkameleon drkameleon added repl Issues related to the REPL 3rd-party Issues related to 3rd-party libraries and code experimental Experimental PRs (may be completely abandoned; or maybe not...) labels Sep 26, 2024
@github-actions github-actions bot removed repl Issues related to the REPL 3rd-party Issues related to 3rd-party libraries and code labels Sep 26, 2024
@github-actions github-actions bot added repl Issues related to the REPL 3rd-party Issues related to 3rd-party libraries and code labels Sep 26, 2024
@github-actions github-actions bot added the helpers Issues related to Helper modules label Sep 26, 2024
@drkameleon
why would it return *that*?!
b940765
@drkameleon
re-fix this too (= nothing to discard)
23e52a8
@drkameleon
so, no userdata anymore...
35d670d
@drkameleon
and no userdata here either...
754d076
@drkameleon
temporarily disable Windows builds
3e315fb 
So, that we can at least reach the point where the other OS'es complete the process and upload some artifacts (that we could then use for testing)
@github-actions github-actions bot added the workflows Issues related to GitHub workflows, building, releases, etc label Sep 26, 2024
@Eloitor Eloitor changed the title [EXPERIMENT] linenoise [EXPERIMENT] linenoise (antirez/linenoise + msteveb/linenoise) Sep 26, 2024
@drkameleon drkameleon mentioned this pull request Oct 21, 2024
Open
@drkameleon drkameleon marked this pull request as draft November 9, 2024 10:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3rd-party Issues related to 3rd-party libraries and code experimental Experimental PRs (may be completely abandoned; or maybe not...) helpers Issues related to Helper modules repl Issues related to the REPL workflows Issues related to GitHub workflows, building, releases, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eloitor @drkameleon