Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Strings\numeric?] make it work consistently #1848

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Strings\numeric?] make it work consistently #1848

wants to merge 2 commits into from

Conversation

drkameleon
Copy link
Collaborator

Description

See also: https://discord.com/channels/765519132186640445/829324913097048065/1325722145250086923

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (implementation update, or general performance enhancements)

@drkameleon drkameleon added bug Something isn't working enhancement New feature or request → Strings labels Jan 6, 2025
@RickBarretto
Copy link
Collaborator

The reason why this behaves that was is very simple.

$> numeric? "."
=> true

$> to :floating "."
=> 0.0

$> numeric? "0.0"
=> true

to :floating "." is parsed to 0.0. This is not inconsistent, I would say. But, should this behavior like this?

@drkameleon
Merge branch 'master' of https://github.com/arturo-lang/arturo into f…
01aaa1d 
…ix-Strings-numeric-to-work-consistently

# Conflicts:
#	version/build
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
Prepare for v0.9.84 🎯
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drkameleon @RickBarretto