-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Types\to] add unit-tests #1917
[Types\to] add unit-tests #1917
Conversation
|
Everything is set-up. I've just created it into one file, but this should be split into multiple ones in other PR. Right now, this covers most of our convertions, and allow us to expand our code without regressions. Also, this PR depends on #1917. Please merge this after that. 😉 The current situation:
Those skipped tests reminds me which conversions I should cover as impossible or makes me think about how this should be handled. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job as usual! 🚀 (and a very thorough one at that... 😉 )
P.S.
(I) Just remember that >>
is our alias for write
:) (I'm not saying that you change it, I'm just saying I was initially confused when I saw it - for internal files, it's perfectly fine; provided we don't... confuse anyone)
(II) If you think it's ready, I'm merging it! 😉 (Not sure, since it's still a draft - asking to make double-sure!)
@drkameleon you're right. I'm thinking about changing it, so I won't confuse anyone. Neither conflict with other tests. I forgot to mention, but this PR aims #1913 and #1914. I tried to deprecate them and move their functions to So, I decided to initiate the first step of the cycle: test -> refactor -> change. I can't change it if I'm not sure about the behavior. Also, can't change if I don't know what I'm changing... I'll use another symbol to tuples tomorrow. And let you know when its finished. 😉 |
Don't worry about it - leave that to me. It's not precisely nothing + I think I could have a good % of it complete until tomorrow, max. (I was planning it actually) And then you can focus on tests yourself. 😉
I wouldn't worry too much; I just mentioned it since I went through the code and I'm like "what are we writing where here?" 🤔 lol
😉 |
@drkameleon ready to merge? |
No worries, at least you can change with without fear. 😉 |
Let's go for it. Very nice job! 😉 And... ready to merge! 🚀 |
Description
convertedValueToType
works fine + add tests #1354Type of change