Skip to content

Commit

Permalink
remove default scale warning in compare (#1412)
Browse files Browse the repository at this point in the history
* remove default scale warning in compare

loo and waic had it removed already IIRC

* update changelog
  • Loading branch information
OriolAbril authored Oct 5, 2020
1 parent 0f10e0a commit 9c6e95e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* prevent wrapping group names in InferenceData repr_html ([1407](https://github.com/arviz-devs/arviz/pull/1407))
* Updated CmdStanPy interface ([1409](https://github.com/arviz-devs/arviz/pull/1409))
* prevent wrapping group names in InferenceData repr_html ([1407](https://github.com/arviz-devs/arviz/pull/1407))
* Remove left out warning about default IC scale in `compare` ([1412](https://github.com/arviz-devs/arviz/pull/1412))

### Deprecation

Expand Down
6 changes: 0 additions & 6 deletions arviz/stats/stats.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,6 @@ def compare(
if scale == "log":
scale_value = 1
ascending = False
warnings.warn(
"\nThe scale is now log by default. Use 'scale' argument or "
"'stats.ic_scale' rcParam if you rely on a specific value.\nA higher "
"log-score (or a lower deviance) indicates a model with better predictive "
"accuracy."
)
else:
if scale == "negative_log":
scale_value = -1
Expand Down

0 comments on commit 9c6e95e

Please # to comment.