Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix bug in plot_loo_pit with use_hdi #1214

Closed
wants to merge 1 commit into from
Closed

fix bug in plot_loo_pit with use_hdi #1214

wants to merge 1 commit into from

Conversation

OriolAbril
Copy link
Member

Description

Checklist

@aloctavodia
Copy link
Contributor

aloctavodia commented May 29, 2020

My original intention was to create a separated PR, but maybe we can go with this.

This makes two important changes. compute the kde over the data range (not over 0, 1). This help to spots problems, as the KDE is "not adding data". Compare our example in the gallery, with the new version.

lala.

This also introduce a theoretical HDI, instead of estimating the HDI from the samples.

lala_hdi

maybe we should enforce the zero y-bottom-limit.

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #1214 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
- Coverage   93.14%   93.07%   -0.07%     
==========================================
  Files          94       94              
  Lines        9497     9503       +6     
==========================================
- Hits         8846     8845       -1     
- Misses        651      658       +7     
Impacted Files Coverage Δ
arviz/plots/backends/bokeh/loopitplot.py 89.18% <100.00%> (+0.30%) ⬆️
arviz/plots/backends/matplotlib/loopitplot.py 97.22% <100.00%> (+0.44%) ⬆️
arviz/plots/loopitplot.py 98.87% <100.00%> (ø)
arviz/plots/hdiplot.py 83.92% <0.00%> (-3.58%) ⬇️
arviz/utils.py 89.33% <0.00%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec33b4c...ff1f320. Read the comment docs.

@aloctavodia
Copy link
Contributor

Sorry for the mess I am closing this in favor of #1215

@OriolAbril OriolAbril deleted the loo_pit branch June 17, 2020 15:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants