Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Inference data example with circular variables #1265

Merged
merged 3 commits into from
Jun 27, 2020
Merged

Add Inference data example with circular variables #1265

merged 3 commits into from
Jun 27, 2020

Conversation

agustinaarroyuelo
Copy link
Contributor

@agustinaarroyuelo agustinaarroyuelo commented Jun 24, 2020

Description

This PR adds a new inference data example. It contains circular variables, which will be useful for testing the new features developed in my GSoC 2020 project.

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1265 into master will increase coverage by 1.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   91.58%   93.21%   +1.63%     
==========================================
  Files          98       98              
  Lines        9734     9734              
==========================================
+ Hits         8915     9074     +159     
+ Misses        819      660     -159     
Impacted Files Coverage Δ
arviz/data/datasets.py 98.38% <ø> (ø)
arviz/data/io_emcee.py 98.33% <0.00%> (+2.50%) ⬆️
arviz/data/io_pystan.py 98.67% <0.00%> (+34.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f1d98...78eb236. Read the comment docs.

@agustinaarroyuelo agustinaarroyuelo changed the title Add Inference data object with circular variables Add Inference data example with circular variables Jun 24, 2020
CHANGELOG.md Outdated
@@ -2,6 +2,7 @@

## v0.x.x Unreleased
### New features
* Added InferenceData object containing circular variables (#1265)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use example or dataset instead of object

@aloctavodia aloctavodia merged commit ba2b684 into arviz-devs:master Jun 27, 2020
@aloctavodia
Copy link
Contributor

Thanks @agustinaarroyuelo

@agustinaarroyuelo agustinaarroyuelo deleted the new_ido branch July 1, 2020 18:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants