Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Circular traceplot for matplotlib #1336

Merged
merged 10 commits into from
Aug 14, 2020
Merged

Circular traceplot for matplotlib #1336

merged 10 commits into from
Aug 14, 2020

Conversation

agustinaarroyuelo
Copy link
Contributor

@agustinaarroyuelo agustinaarroyuelo commented Aug 4, 2020

Description

In this PR I am adding argument circ_var_names to plot_trace in order to obtain a plot like this:

traceplot_circ

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@agustinaarroyuelo agustinaarroyuelo changed the title [WIP] Circular traceplot for matplotlib Circular traceplot for matplotlib Aug 6, 2020
Copy link
Contributor

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add one example to the example gallery?

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #1336 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
+ Coverage   91.77%   91.79%   +0.02%     
==========================================
  Files         101      101              
  Lines       10622    10634      +12     
==========================================
+ Hits         9748     9762      +14     
+ Misses        874      872       -2     
Impacted Files Coverage Δ
arviz/plots/backends/bokeh/traceplot.py 94.44% <ø> (ø)
arviz/plots/traceplot.py 95.12% <ø> (ø)
arviz/plots/backends/matplotlib/traceplot.py 99.36% <100.00%> (+0.05%) ⬆️
arviz/plots/backends/bokeh/forestplot.py 92.85% <0.00%> (+0.32%) ⬆️
arviz/plots/backends/matplotlib/forestplot.py 97.92% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee3c26...c076478. Read the comment docs.

@aloctavodia aloctavodia merged commit ea60cd5 into arviz-devs:master Aug 14, 2020
@agustinaarroyuelo agustinaarroyuelo deleted the circ_traceplot_mpl branch August 14, 2020 13:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants