Read model info to attrs with from_pystan
#1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 91.80% 91.74% -0.06%
==========================================
Files 101 101
Lines 10636 10697 +61
==========================================
+ Hits 9764 9814 +50
- Misses 872 883 +11
Continue to review full report at Codecov.
|
added 6 commits
August 16, 2020 17:32
ahartikainen
force-pushed
the
feature/pystan_metadata
branch
from
ff0e8f7 to
fb4c902
Compare
ColCarroll
approved these changes
Aug 16, 2020
| flags=re.IGNORECASE, | ||
| ).group(1) | ||
| ) | ||
| except AttributeError: |
There was a problem hiding this comment.
is attribute error what happens when re.search returns None, which has no .group attribute?
There was a problem hiding this comment.
Yes, my lazy solution. "comment" field should still have the raw value.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add PyStan metadata info.
Checklist