Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix multi rope for forest plot #1390

Merged
merged 3 commits into from
Sep 21, 2020
Merged

fix multi rope for forest plot #1390

merged 3 commits into from
Sep 21, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Sep 21, 2020

Fix #1382

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@aloctavodia aloctavodia changed the title fix multi rope fix multi rope for forest plot Sep 21, 2020
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1390 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1390   +/-   ##
=======================================
  Coverage   91.72%   91.73%           
=======================================
  Files         105      105           
  Lines       10901    10909    +8     
=======================================
+ Hits         9999    10007    +8     
  Misses        902      902           
Impacted Files Coverage Δ
arviz/plots/forestplot.py 91.17% <ø> (ø)
arviz/plots/backends/bokeh/forestplot.py 94.68% <100.00%> (+0.06%) ⬆️
arviz/plots/backends/matplotlib/forestplot.py 98.03% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9a194...7b012c8. Read the comment docs.

@OriolAbril OriolAbril merged commit 652302f into master Sep 21, 2020
@OriolAbril OriolAbril deleted the forest_plot_rope branch September 21, 2020 22:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to have a different rope for every variable dimension
3 participants