Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix typo in distplot.py #1414

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Conversation

jrosellr
Copy link
Contributor

@jrosellr jrosellr commented Oct 11, 2020

Description

I fixed a typo in plots/distplot.py, changing the description of a ValueError.

Fixes: #1413

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@jrosellr jrosellr mentioned this pull request Oct 11, 2020
@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #1414 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1414   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         105      105           
  Lines       11061    11061           
=======================================
  Hits        10135    10135           
  Misses        926      926           
Impacted Files Coverage Δ
arviz/plots/distplot.py 90.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fde505...a208da8. Read the comment docs.

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I'll merge once the change is added to the changelog under the maintenance and fixes section.

@jrosellr jrosellr changed the title Fix typo in distplot.py update changelog Oct 12, 2020
@jrosellr
Copy link
Contributor Author

I'm glad to help! I wasn't sure if I had to update the changelog for a typo fix, I listed the changes under Maintenance/Fixes in the unreleased section.

@aloctavodia aloctavodia changed the title update changelog Fix typo in distplot.py Oct 12, 2020
@aloctavodia
Copy link
Contributor

Thanks @JoanRosell for your help. Notice I revert back the title to "Fix typo in distplot.py". That was a good title.

@aloctavodia aloctavodia merged commit d344da1 into arviz-devs:master Oct 12, 2020
@jrosellr jrosellr deleted the fix-typo-plot_dist branch October 12, 2020 11:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in plot_dist
3 participants