Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

plot_rank: add ref_line, bar, vlines and marker_vlines kwargs #1419

Merged
merged 5 commits into from
Oct 23, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Oct 15, 2020

Fix #1396

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

idata = az.load_arviz_data("centered_eight")
az.plot_rank(idata, var_names="mu", kind="vlines", vlines_kwargs={'lw':0}, marker_vlines_kwargs={'lw':3});
index

az.plot_rank(idata, var_names="mu", ref_line_kwargs={"line_width":2, "line_color":"gray"},
bar_kwargs={"width":50}, backend="bokeh");
bokeh_plot

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1419 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
+ Coverage   91.56%   91.59%   +0.02%     
==========================================
  Files         105      105              
  Lines       11098    11137      +39     
==========================================
+ Hits        10162    10201      +39     
  Misses        936      936              
Impacted Files Coverage Δ
arviz/plots/rankplot.py 90.32% <ø> (ø)
arviz/plots/backends/bokeh/ppcplot.py 97.69% <100.00%> (+0.11%) ⬆️
arviz/plots/backends/bokeh/rankplot.py 94.66% <100.00%> (+1.22%) ⬆️
arviz/plots/backends/matplotlib/ppcplot.py 98.10% <100.00%> (+0.02%) ⬆️
arviz/plots/backends/matplotlib/rankplot.py 96.96% <100.00%> (+0.96%) ⬆️
arviz/plots/ppcplot.py 93.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4e188...6f67d02. Read the comment docs.

@aloctavodia aloctavodia merged commit 9997735 into master Oct 23, 2020
@aloctavodia aloctavodia deleted the plot_rank_kwargs branch October 23, 2020 14:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_rank ignores backend_kwargs
2 participants