-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CI Update Python #1430
CI Update Python #1430
Conversation
We should also update the readme: https://github.com/arviz-devs/arviz#dependencies and the setup.py: https://github.com/arviz-devs/arviz/blob/master/setup.py#L69-L71. |
2881252
to
5692044
Compare
dc10425
to
fbef334
Compare
Rebased on master |
Tensorflow is not available on 3.9 yet tensorflow/tensorflow#44485 |
Neither is pystan3 |
Got it, should we keep PR on hold until then? |
Yes (and clean it a bit) |
Any news on that? Should we merge and drop python 3.6 in the coming release or wait for the next one? @canyon289 @ahartikainen |
Wait. Some packages are still missing. |
I think we should drop python 3.6 in the next release (most pydata packages have already done). I am adding it to the milestone, feel free to remove if you think we still should wait |
fbef334
to
0270704
Compare
b1d9c86
to
f85afd0
Compare
This is following numpy's advise on releasing and python supports
reduced wheel size from >800Mb to ~200Mb
Codecov Report
@@ Coverage Diff @@
## main #1430 +/- ##
==========================================
- Coverage 91.72% 91.66% -0.06%
==========================================
Files 116 116
Lines 12362 12362
==========================================
- Hits 11339 11332 -7
- Misses 1023 1030 +7
Continue to review full report at Codecov.
|
Just for future reference, numpy has already stopped 3.7 support (https://github.com/numpy/numpy/blob/main/setup.py#L34), so not too long from now once numba supports 3.10 we should change 3.7 for 3.10. Should be ready to merge now |
seems like I can't tag @ahartikainen for review as it's his PR |
Lgtm |
Description
Update Python versions. Drop 3.6 checks.
New default Python is 3.9.