Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI Update Python #1430

Merged
merged 19 commits into from
Nov 14, 2021
Merged

CI Update Python #1430

merged 19 commits into from
Nov 14, 2021

Conversation

ahartikainen
Copy link
Contributor

Description

Update Python versions. Drop 3.6 checks.

New default Python is 3.9.

@OriolAbril
Copy link
Member

@canyon289
Copy link
Member

Rebased on master

@canyon289
Copy link
Member

Tensorflow is not available on 3.9 yet tensorflow/tensorflow#44485

@ahartikainen
Copy link
Contributor Author

Neither is pystan3

@canyon289
Copy link
Member

Got it, should we keep PR on hold until then?

@ahartikainen
Copy link
Contributor Author

Yes (and clean it a bit)

@OriolAbril
Copy link
Member

Any news on that? Should we merge and drop python 3.6 in the coming release or wait for the next one? @canyon289 @ahartikainen

@ahartikainen
Copy link
Contributor Author

Wait. Some packages are still missing.

Base automatically changed from master to main January 26, 2021 19:44
@OriolAbril
Copy link
Member

I think we should drop python 3.6 in the next release (most pydata packages have already done). I am adding it to the milestone, feel free to remove if you think we still should wait

This is following numpy's advise on releasing and python supports
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #1430 (8874c4f) into main (ff796cf) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
- Coverage   91.72%   91.66%   -0.06%     
==========================================
  Files         116      116              
  Lines       12362    12362              
==========================================
- Hits        11339    11332       -7     
- Misses       1023     1030       +7     
Impacted Files Coverage Δ
arviz/data/inference_data.py 83.76% <100.00%> (ø)
arviz/utils.py 88.23% <0.00%> (-0.99%) ⬇️
arviz/rcparams.py 93.33% <0.00%> (-0.84%) ⬇️
arviz/stats/stats.py 96.28% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff796cf...8874c4f. Read the comment docs.

@OriolAbril
Copy link
Member

OriolAbril commented Nov 14, 2021

Just for future reference, numpy has already stopped 3.7 support (https://github.com/numpy/numpy/blob/main/setup.py#L34), so not too long from now once numba supports 3.10 we should change 3.7 for 3.10. Should be ready to merge now

@OriolAbril OriolAbril requested a review from canyon289 November 14, 2021 10:17
@OriolAbril
Copy link
Member

seems like I can't tag @ahartikainen for review as it's his PR

@OriolAbril OriolAbril marked this pull request as ready for review November 14, 2021 10:18
@ahartikainen
Copy link
Contributor Author

Lgtm

@ahartikainen ahartikainen merged commit 01aed48 into main Nov 14, 2021
@ahartikainen ahartikainen deleted the update/ci_python branch November 14, 2021 16:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants