Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix in-sample deviance #1435

Merged
merged 4 commits into from
Nov 4, 2020
Merged

fix in-sample deviance #1435

merged 4 commits into from
Nov 4, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Nov 2, 2020

Fix #1288

When computing the "in-sample deviance" we were adding the wrong factor, except for the "deviance" scale.

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1435 into master will decrease coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
- Coverage   91.99%   91.91%   -0.08%     
==========================================
  Files         105      105              
  Lines       11184    11200      +16     
==========================================
+ Hits        10289    10295       +6     
- Misses        895      905      +10     
Impacted Files Coverage Δ
arviz/plots/backends/bokeh/compareplot.py 91.07% <50.00%> (-8.93%) ⬇️
arviz/plots/backends/matplotlib/compareplot.py 86.95% <50.00%> (-10.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6603e6...5ecf3c4. Read the comment docs.

@aloctavodia aloctavodia merged commit c03e90e into master Nov 4, 2020
@aloctavodia aloctavodia deleted the plot_comp branch November 4, 2020 11:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_compare issue with pWAIC
1 participant