Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix type mismatches in traceplot.py. #1497

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

obi1kenobi
Copy link
Contributor

Description

Fixing a couple more mypy errors, closing in toward #1496:

arviz/plots/traceplot.py:23: error: Incompatible default for argument "circ_var_units" (default has type "str", argument has type "bool")  [assignment]
arviz/plots/traceplot.py:163: error: Incompatible types in assignment (expression has type "bool", variable has type "Optional[str]")  [assignment]

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1497 (fa86ac7) into master (fff2b2f) will increase coverage by 1.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
+ Coverage   90.37%   91.92%   +1.54%     
==========================================
  Files         105      105              
  Lines       11246    11246              
==========================================
+ Hits        10164    10338     +174     
+ Misses       1082      908     -174     
Impacted Files Coverage Δ
arviz/plots/traceplot.py 95.12% <100.00%> (ø)
arviz/data/io_emcee.py 98.33% <0.00%> (+2.50%) ⬆️
arviz/data/io_pystan.py 96.00% <0.00%> (+32.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff2b2f...fa86ac7. Read the comment docs.

@OriolAbril OriolAbril merged commit 26a11d1 into arviz-devs:master Jan 16, 2021
@obi1kenobi obi1kenobi deleted the fix_traceplot_types branch January 16, 2021 05:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants