-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[WIP] Add Dataframe to Inference Data Example to cookbook #1556
Conversation
Hi, @OriolAbril can you check the PR and provide anything which I need to update and also the problem which I suggested in the description. Thanks |
I would use Regarding the attributes, do not worry about it. Attributes are added when converting to |
Thank You for your feedback @OriolAbril, I will change the |
Yes, you can ignore them for now |
@OriolAbril is there anything more which I need to update? Thanks |
Can you rebase with the latest changes from main and then add a bullet point about the change in the changelog? |
3b806c4
to
23975d3
Compare
Codecov Report
@@ Coverage Diff @@
## main #1556 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 105 105
Lines 11397 11397
=======================================
Hits 10289 10289
Misses 1108 1108 Continue to review full report at Codecov.
|
Thanks @Rishabh261998 ! |
@OriolAbril I was just going through the CHANGELOG.md file and just found out a typo. The first bullet point in the unreleased version links to the PR 1535 but should link to 1518. Thanks |
Thanks, we can fix this in #1550 |
* Added Dataframe to InfData Example * Changed convert_to_inference_data to InferenceData * Updated CHANGELOG.md
Description
closes #1490
This is an update on the issue "Add dataframe to InfData examples to cookbook" #1490 I have added the example but there seems to be a problem i.e the created inference object does not have any attributes(eg: created_at, arviz_version). Could you help me tackle this and also provide your feedback. Thanks