Fix pareto k threshold typo in reloo function #1580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that changing the
k_thresh
argument to the functionreloo
from the default value 0.7 had no effect. I think this is because the threshold is accidentally hard-coded as 0.7 inside the function.This change fixes the apparent typo, replacing 0.7 with
k_thresh
.Checklist
This function is so far untested and I didn't think it made sense to write a whole test before fixing this bug.