[WIP] improvement suggestions for the label guide documentation (until sorting dimensions chapter) #1699

Eva-Lotte · 2021-05-20T11:38:14Z

Description

codecov · 2021-05-20T12:05:14Z

Codecov Report

Merging #1699 (01fadad) into main (1a39374) will not change coverage.
The diff coverage is n/a.

❗ Current head 01fadad differs from pull request most recent head 549b643. Consider uploading reports for the commit 549b643 to get more accurate results

@@           Coverage Diff           @@
##             main    #1699   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         108      108           
  Lines       11818    11818           
=======================================
  Hits        10738    10738           
  Misses       1080     1080

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a39374...549b643. Read the comment docs.

OriolAbril

Thanks ❤️ these really improve the clarity of the guide.

OriolAbril · 2021-05-20T16:02:45Z

doc/source/user_guide/label_guide.rst

-Provided we know that the coordinate values shown for theta correspond to the `school` dimension,
-we can plot only ``tau`` to better inspect it's 1.03 :func:`~arviz.rhat` and
-``theta`` for ``Choate`` and ``St. Paul's``, the ones with higher means:
+ArviZ supports label based indexing.


I would like to still be explicit about xarray even though I'm not sure how.

Many users only use ArviZ functions, plots and diagnostics and are not aware that all of that is powered by xarray under the hood. This is particularly relevant for researchers who then don't cite xarray when publishing even though they did cite ArviZ. It is not "our" problem per se, but I think we should try to nudge users towards the right citations and it is also bad for us indirectly because xarray is generally undercited which dificults it getting grants and slows down its development.

OriolAbril · 2021-05-20T16:18:17Z

doc/source/user_guide/label_guide.rst

+For a case where the coordinate values shown for the theta variable correspond to the `school` dimension
+you can plot only the ``tau`` variable to better inspect its 1.03 :func:`~arviz.rhat` value,
+only the ``theta`` variable to the ``Choate`` and ``St. Paul's`` coordinates, which have higher means, you can ploy only the ``theta`` variable by running the following command:


My original description wasn't very good, but it tried to say that we are plotting all the things that were described, we are not plotting only the theta variable. How about something like:

Given that summary by default shows the coordinate values and not their indices or some aliases, you can use what you see to subset the data. The summary shows that ``tau`` has 1.03 :func:`~arviz.rhat` value which deserves closer inspection. You can indicate ArviZ to plot ``tau`` by including it in the ``var_names`` argument. Moreover, you may also want to inspect closely the ``theta`` values for the ``Choate`` and ``St. Paul's`` coordinates because of their higher means. You can do so by including ``theta`` too in ``var_names`` and using the ``coords`` argument to select only these two coordinate values for the ``school`` dimension. You can generate this plot with the following command:

doc/source/user_guide/label_guide.rst

OriolAbril · 2021-05-20T16:21:55Z

doc/source/user_guide/label_guide.rst


-Fear not, we can use the labeller argument to customize the labels.
-The ``arviz.labels`` module contains some classes that cover some common customization classes.
+To create a report on Deerfield, Hotchkiss and Lawrenceville schools for the probability of ``theta > 5``, use the labeller argument to customize labels. 


Suggested change

To create a report on Deerfield, Hotchkiss and Lawrenceville schools for the probability of ``theta > 5``, use the labeller argument to customize labels.

You'll now create a report on Deerfield, Hotchkiss and Lawrenceville schools for the probability of ``theta > 5`` and use the labeller argument to customize labels.

OriolAbril · 2021-05-20T16:27:42Z

doc/source/user_guide/label_guide.rst

+~~~~~~~~~~~~~~~~~~~~
+
+- For a list of labellers available in ArviZ, see the :ref:`the API reference page <labeller_api>`.
+- For common customization classes, see the ``arviz.labels`` module.


The api reference has the docs for the arviz.labels module, the original last line tried to give a choice to readers. At this point they have seen how to use the labeller argument. Therefore, if they only want to do some more or less simple changes to the labels, they don't need to continue reading this guide, but they will probably need to read the api reference to find the class that suits their needs (which may be IdxLabeller instead of MapLabeller). Does this make sense? Maybe deleting this 2nd bullet point is enough already?

Also, how about using the seealso directive? https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-seealso

Thank you for the hint with the seealso directive! This is what I was looking for.

doc/source/user_guide/label_guide.rst

OriolAbril · 2021-05-20T16:36:25Z

doc/source/user_guide/label_guide.rst

@@ -97,22 +104,25 @@ Sorting variable names
 Sorting coordinate values
 .........................

-We may also want to sort the schools by their mean.
-To do so we first have to get the means of each school:
+To sort coordinate values by mean you have to locate the means of each school and then use the DataArray result to sort the coordinate values. 


Suggested change

To sort coordinate values by mean you have to locate the means of each school and then use the DataArray result to sort the coordinate values.

To sort coordinate values you have to first define the order and store it, then use that result to sort the coordinate values.

doc/source/user_guide/label_guide.rst

Eva-Lotte · 2021-05-21T08:33:08Z

Thank you very much for your review!

OriolAbril · 2021-05-21T11:38:20Z

doc/source/user_guide/label_guide.rst


 Example: Using the labeller argument
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

-To create a report on Deerfield, Hotchkiss and Lawrenceville schools for the probability of ``theta > 5``, use the labeller argument to customize labels. 
+To create a report on Deerfield, Hotchkiss and Lawrenceville schools for the probability of ``theta > 5`` and use the labeller argument to customize labels. 


This sentence now feels incomplete. It starts with "to create" and a description on what to create but nothing on how to create it.

A bit more context in case it helps. Here there are two goals: creating a report of theta > 5 and using the labeller to customize the labels.

One can be done without the other, but instead of showing how to use the labeller (which I think should be done in the example in he docstring that is still wip), I wanted to show how to use the labeller to solve a more specific and real task. When exploring the mode ourselves, we won't generally care much about the labels, having the same thing as the code is fine. However, if generating a report to be published or presented, we'll probably want to take better care of the presentation, and match the labels to the labels in the equations of the paper instead of variables in the code. Hence the MapLabeller

Thank you for providing a bit of context to this matter. The way I see it, since this piece of text is inside of the example, we don't even need the first part of the sentence.

doc/source/user_guide/label_guide.rst

OriolAbril · 2021-05-21T11:51:26Z

doc/source/user_guide/label_guide.rst

@@ -97,22 +103,25 @@ Sorting variable names
 Sorting coordinate values
 .........................

-We may also want to sort the schools by their mean.
-To do so we first have to get the means of each school:
+To sort coordinate values you have to define the order, store it, and use the result to sort the coordinate values. 


Suggested change

To sort coordinate values you have to define the order, store it, and use the result to sort the coordinate values.

To sort coordinate values you have to define the order, store it, and use the result to sort the coordinate values.

The order can be defined by performing some operations on our xarray objects (like it is shown in the example below)

or by manually creating a list with the desired order.

Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>

…ttps://github.com/Eva-Lotte/arviz into label-guide-documentation-improvement-suggestions

OriolAbril

Looks great, only thing missing is adding to the changelog and merging.

Eva-Lotte · 2021-05-27T11:34:17Z

Thank you, Oriol! I added the changes to the changelog! I can't seem to merge the PR, probably because of access rights?

OriolAbril · 2021-05-27T16:14:33Z

Yeah, only core contributors have merge privilieges, I wasn't very clear in my previous post. Thanks for the PR!

…tation (arviz-devs#1699) * documentation improvement suggestions for the label guide * Addressed feedback * Update doc/source/user_guide/label_guide.rst Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com> * feedback addressed * added changes to CHANGELOG.md Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>

documentation improvement suggestions for the label guide

5fae4c8

OriolAbril reviewed May 20, 2021

View reviewed changes

Addressed feedback

01fadad

OriolAbril mentioned this pull request May 21, 2021

Fix typos in arviz codebase #1700

Merged

OriolAbril reviewed May 21, 2021

View reviewed changes

Eva-Lotte and others added 3 commits May 24, 2021 09:39

Update doc/source/user_guide/label_guide.rst

549b643

Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>

feedback addressed

2545612

Merge branch 'label-guide-documentation-improvement-suggestions' of h…

d08de38

…ttps://github.com/Eva-Lotte/arviz into label-guide-documentation-improvement-suggestions

OriolAbril approved these changes May 24, 2021

View reviewed changes

added changes to CHANGELOG.md

49b9468

OriolAbril merged commit 1997afe into arviz-devs:main May 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] improvement suggestions for the label guide documentation (until sorting dimensions chapter) #1699

[WIP] improvement suggestions for the label guide documentation (until sorting dimensions chapter) #1699

Eva-Lotte commented May 20, 2021

codecov bot commented May 20, 2021 •

edited

Loading

OriolAbril left a comment

OriolAbril May 20, 2021 •

edited

Loading

OriolAbril May 20, 2021

OriolAbril May 20, 2021

OriolAbril May 20, 2021

Eva-Lotte May 21, 2021

OriolAbril May 20, 2021

Eva-Lotte commented May 21, 2021

OriolAbril May 21, 2021

Eva-Lotte May 24, 2021

OriolAbril May 21, 2021

OriolAbril left a comment

Eva-Lotte commented May 27, 2021

OriolAbril commented May 27, 2021

	To create a report on Deerfield, Hotchkiss and Lawrenceville schools for the probability of ``theta > 5``, use the labeller argument to customize labels.
	You'll now create a report on Deerfield, Hotchkiss and Lawrenceville schools for the probability of ``theta > 5`` and use the labeller argument to customize labels.

	To sort coordinate values by mean you have to locate the means of each school and then use the DataArray result to sort the coordinate values.
	To sort coordinate values you have to first define the order and store it, then use that result to sort the coordinate values.

[WIP] improvement suggestions for the label guide documentation (until sorting dimensions chapter) #1699

[WIP] improvement suggestions for the label guide documentation (until sorting dimensions chapter) #1699

Conversation

Eva-Lotte commented May 20, 2021

Description

codecov bot commented May 20, 2021 • edited Loading

Codecov Report

OriolAbril left a comment

Choose a reason for hiding this comment

OriolAbril May 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eva-Lotte commented May 21, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OriolAbril left a comment

Choose a reason for hiding this comment

Eva-Lotte commented May 27, 2021

OriolAbril commented May 27, 2021

codecov bot commented May 20, 2021 •

edited

Loading

OriolAbril May 20, 2021 •

edited

Loading