-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Progressively updated doc references (WIP) #1714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
arviz/plots/hdiplot.py
Outdated
These are kwargs specific to the backend being used, passed to :meth:`mpl:matplotlib.axes.Axes.plot` or | ||
:meth:`bokeh:bokeh.plotting.figure.Figure.patch`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are kwargs specific to the backend being used, passed to :meth:`mpl:matplotlib.axes.Axes.plot` or | |
:meth:`bokeh:bokeh.plotting.figure.Figure.patch`. | |
These are kwargs specific to the backend being used, passed to | |
:meth:`mpl:matplotlib.axes.Axes.plot` or | |
:meth:`bokeh:bokeh.plotting.figure.Figure.patch`. |
pylint is complaining the line is too long: https://dev.azure.com/ArviZ/ArviZ/_build/results?buildId=4420&view=logs&j=8a326fc5-acd0-5109-b239-57a83132e152&t=1e642e4d-ea03-518d-4dda-a3ee822acd3f&l=15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll make the changes
arviz/stats/stats.py
Outdated
.. [1] Using Advanced Plot Types in Kaluza: Comparison Plots for Visualization of the TCR V | ||
Beta Repertoire, see https://www.beckman.com/flow-cytometry/software/kaluza/learning-center/comparison-plot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are called comparison plots too but are actually not related to ours 😅. The reference should be https://doi.org/10.1007/s11222-016-9696-4. pylint is also complaining about the line length, I hope the doi link will be shorter, otherwise I don't really know how to fix that, I'd have to search and ask around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. My bad! Sorry for the confusion. I'll change the reference. Also just to clarify, the references must be linked to a journal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessarily, they can also link to books, websites, or even documentation or examples from other libraries. https://arviz-devs.github.io/arviz/api/generated/arviz.plot_loo_pit.html has one of each for example. They will often be papers though, because arviz aims to implement the latest algorithms which are generally not yet covered in books and are generally published as papers that describe them and show they work as intended.
Hey, I have updated the changes. I'm still getting a trailing whitespace error although I didn't have this issue in VSCode Editor with pylint enabled. Not sure how to fix this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should do it. pylint indicates the problematic line. Trailing whitespaces are often ignored so unless the config used by pylint when run via vscode is exactly the same as arviz one it is not surprising to find extra errors and warning on ci
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1714 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 108 108
Lines 11821 11821
=======================================
Hits 10741 10741
Misses 1080 1080
Continue to review full report at Codecov.
|
Description