Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ppc_plot specify colors for each element #1769

Merged
merged 5 commits into from
Sep 3, 2021
Merged

ppc_plot specify colors for each element #1769

merged 5 commits into from
Sep 3, 2021

Conversation

aloctavodia
Copy link
Contributor

Now we can pass a list of 3 colors instead of a single string

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1769 (0cc3483) into main (189b4da) will increase coverage by 0.04%.
The diff coverage is 94.02%.

❗ Current head 0cc3483 differs from pull request most recent head febef45. Consider uploading reports for the commit febef45 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
+ Coverage   91.17%   91.22%   +0.04%     
==========================================
  Files         115      117       +2     
  Lines       12254    12449     +195     
==========================================
+ Hits        11172    11356     +184     
- Misses       1082     1093      +11     
Impacted Files Coverage Δ
arviz/plots/ppcplot.py 91.54% <66.66%> (-2.30%) ⬇️
arviz/plots/tsplot.py 91.66% <91.66%> (ø)
arviz/data/inference_data.py 83.76% <100.00%> (+0.04%) ⬆️
arviz/plots/__init__.py 100.00% <100.00%> (ø)
arviz/plots/backends/bokeh/ppcplot.py 98.11% <100.00%> (ø)
arviz/plots/backends/matplotlib/ppcplot.py 98.07% <100.00%> (ø)
arviz/plots/backends/matplotlib/tsplot.py 100.00% <100.00%> (ø)
arviz/utils.py 89.21% <100.00%> (+0.07%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189b4da...febef45. Read the comment docs.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ok, but where is the test for making sure that colors list has atleast 3 items?

@aloctavodia aloctavodia merged commit 9b8706d into main Sep 3, 2021
@aloctavodia aloctavodia deleted the colors_ppc branch September 3, 2021 05:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants