Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change order of regularization in psislw (#1941) #1943

Merged
merged 3 commits into from
Dec 4, 2021
Merged

Change order of regularization in psislw (#1941) #1943

merged 3 commits into from
Dec 4, 2021

Conversation

OrchiDorchi
Copy link
Contributor

@OrchiDorchi OrchiDorchi commented Nov 23, 2021 •
edited
Loading

Description

Resolves #1941. Changed the order of regularization of the shape parameter of the generalized Pareto distribution and estimation of scale parameter.

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@OrchiDorchi OrchiDorchi mentioned this pull request Nov 23, 2021
Closed
sethaxen
sethaxen reviewed Dec 2, 2021
View reviewed changes
Copy link
Member

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small formatting tweak to the changelog, then this LGTM! Thanks for the fix!

@OrchiDorchi @sethaxen
Update CHANGELOG.md
ff3c958 
Co-authored-by: Seth Axen <seth.axen@gmail.com>
@OrchiDorchi
Copy link
Contributor Author

Thanks for the review!

@OrchiDorchi
Copy link
Contributor Author

I just updated CHANGELOG but test that passed last week failed now. Is there anything I can do?

@sethaxen
Copy link
Member

sethaxen commented Dec 2, 2021

Looks unrelated to this PR. #1939 seems to have the same error, which happens at the pylint step. Should be fine to merge.

@OrchiDorchi
Copy link
Contributor Author

Thanks for your time, I am waiting for merge.

@sethaxen sethaxen merged commit 60385cd into arviz-devs:main Dec 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sethaxen sethaxen sethaxen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change order of regularization in psislw
2 participants
@OrchiDorchi @sethaxen