Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Labellers testing module #2095

Merged
merged 7 commits into from
Oct 6, 2022
Merged

Conversation

agustinaarroyuelo
Copy link
Contributor

@agustinaarroyuelo agustinaarroyuelo commented Aug 15, 2022

Co-authored-by: Oriol Abril-Pla oriol.abril.pla@gmail.com

Description

Here we will add a new testing module specific for the labeller classes. It will fix #1574.

Checklist

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2095.org.readthedocs.build/en/2095/

Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
agustinaarroyuelo and others added 2 commits September 10, 2022 11:13
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
@agustinaarroyuelo
Copy link
Contributor Author

Thanks for your comments @OriolAbril. I cleaned up the script trying to get a minimum working unit. If we agree on it, we can start adding more tests.

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are passing and I think they can be understood even if focus is probably more on avoiding repetition. I think we can follow this pattern unless maybe @canyon289 has some ideas on how to improve it?

@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #2095 (6a152b2) into main (655c4f7) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
+ Coverage   90.76%   90.88%   +0.11%     
==========================================
  Files         117      117              
  Lines       12501    12501              
==========================================
+ Hits        11347    11361      +14     
+ Misses       1154     1140      -14     
Impacted Files Coverage Δ
arviz/labels.py 94.66% <0.00%> (+18.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@agustinaarroyuelo agustinaarroyuelo changed the title [WIP] Labellers testing module Labellers testing module Sep 24, 2022
@ahartikainen ahartikainen merged commit 8020330 into arviz-devs:main Oct 6, 2022
@agustinaarroyuelo agustinaarroyuelo deleted the test_labels branch October 7, 2022 14:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add tests to arviz.labels module
3 participants