Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates to wrappers and refitting stats #2158

Merged
merged 8 commits into from
Nov 18, 2022

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Nov 9, 2022

Description

I have updated the pymc notebook with the reloo how-to. Now we have versioned docs
so I have deleted the pymc3 ones which won't be lost.
I will also add a cmdstanpy one and maybe remove pystan2 ones

Checklist

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2158.org.readthedocs.build/en/2158/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriolAbril OriolAbril marked this pull request as ready for review November 16, 2022 23:31
@OriolAbril
Copy link
Member Author

Do we still need to test on cmdstanpy <1.0? I can add a pylint disable or update the tests to check latest release and github dev version. cc @ahartikainen @mitzimorris

@ahartikainen
Copy link
Contributor

No we don't

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #2158 (9537f09) into main (499e138) will decrease coverage by 0.90%.
The diff coverage is 41.37%.

@@            Coverage Diff             @@
##             main    #2158      +/-   ##
==========================================
- Coverage   90.68%   89.77%   -0.91%     
==========================================
  Files         120      121       +1     
  Lines       12679    12700      +21     
==========================================
- Hits        11498    11402      -96     
- Misses       1181     1298     +117     
Impacted Files Coverage Δ
arviz/stats/stats_refitting.py 17.77% <0.00%> (ø)
arviz/wrappers/wrap_stan.py 40.54% <40.00%> (-2.32%) ⬇️
arviz/wrappers/wrap_pymc.py 45.45% <45.45%> (ø)
arviz/wrappers/__init__.py 100.00% <100.00%> (ø)
arviz/data/io_cmdstanpy.py 60.63% <0.00%> (-33.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriolAbril
Copy link
Member Author

Should be ready to merge

@ahartikainen ahartikainen merged commit 5039c35 into arviz-devs:main Nov 18, 2022
@OriolAbril OriolAbril deleted the wrappers branch November 18, 2022 23:37
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 22, 2023
https://build.opensuse.org/request/show/1073712
by user dgarcia + dimstar_suse
- skip python 3.11 and python 3.8 because some dependencies doesn't
  support that python versions
- Update to 0.15.1
  - Fix memory usage and improve efficiency in `from_emcee`
    ([2215](arviz-devs/arviz#2215))
  - Lower pandas version needed
    ([2217](arviz-devs/arviz#2217))
- 0.15.0
  - Adds Savage-Dickey density ratio plot for Bayes factor
    approximation.
    ([2037](arviz-devs/arviz#2037),
    [2152](arviz-devs/arviz#2152))
  - Add `CmdStanPySamplingWrapper` and `PyMCSamplingWrapper` classes
    ([2158](arviz-devs/arviz#2158))
  - Changed dependency on netcdf4-python to h5netcdf
    ([2122](arviz-devs/arviz#2122))
  - Fix `reloo` outdate
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants