Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

updated np.product to np.prod #2249

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

Surya-Narayan
Copy link
Contributor

@Surya-Narayan Surya-Narayan commented Jun 10, 2023

Fix #2248
np.product is deprecated from numpy v1.25 and above. Replaced np.product to np.prod

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2249.org.readthedocs.build/en/2249/

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #2249 (988fa5a) into main (353508d) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main    #2249   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         120      120           
  Lines       12433    12433           
=======================================
  Hits        10929    10929           
  Misses       1504     1504           
Impacted Files Coverage Δ
arviz/data/io_pystan.py 51.18% <0.00%> (ø)
arviz/stats/density_utils.py 79.17% <100.00%> (ø)
arviz/stats/stats.py 95.25% <100.00%> (ø)

@ahartikainen ahartikainen mentioned this pull request Jun 10, 2023
6 tasks
nilanjan2002
nilanjan2002 approved these changes Jun 10, 2023
@Surya-Narayan
Copy link
Contributor Author

@ahartikainen Is there any issue with the changes I have made?

@OriolAbril OriolAbril changed the title updated np.product to np.prod. issue #2248 updated np.product to np.prod Jun 12, 2023
@OriolAbril OriolAbril merged commit f2d1f11 into arviz-devs:main Jun 12, 2023
@OriolAbril
Copy link
Member

Thanks @Surya-Narayan !

@Surya-Narayan
Copy link
Contributor Author

Thank you :)

@Surya-Narayan Surya-Narayan deleted the feature/update-np.product branch July 7, 2023 10:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

np.product is deprecated in numpy v1.25
3 participants