-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
updated np.product to np.prod #2249
Merged
OriolAbril
merged 3 commits into
arviz-devs:main
from
Surya-Narayan:feature/update-np.product
Jun 12, 2023
Merged
updated np.product to np.prod #2249
OriolAbril
merged 3 commits into
arviz-devs:main
from
Surya-Narayan:feature/update-np.product
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed np.product to np.prod in 3 files
Codecov Report
@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 120 120
Lines 12433 12433
=======================================
Hits 10929 10929
Misses 1504 1504
|
@ahartikainen Is there any issue with the changes I have made? |
OriolAbril
reviewed
Jun 12, 2023
OriolAbril
approved these changes
Jun 12, 2023
Thanks @Surya-Narayan ! |
Thank you :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2248
np.product is deprecated from numpy v1.25 and above. Replaced np.product to np.prod
Checklist
📚 Documentation preview 📚: https://arviz--2249.org.readthedocs.build/en/2249/