Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove parallel from arviz.utils.full (fixes #904) #996

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

nitishp25
Copy link
Contributor

@nitishp25 nitishp25 commented Jan 14, 2020

Removed parallel arguement from numba @conditional_jit in arviz.utils.full

fixes #904

@nitishp25
Copy link
Contributor Author

@OriolAbril Please review :)

@OriolAbril
Copy link
Member

Hi, you should rebase your remove-parallel-from-full branch. If you have followed the steps in the contributing guide you will only need these two lines from step 5:

$ git fetch upstream
$ git rebase upstream/master

Otherwise you will have to add the upstream remote as explained in step 2:

$ git remote add upstream git@github.com:arviz-devs/arviz.git

@nitishp25
Copy link
Contributor Author

nitishp25 commented Jan 14, 2020

@OriolAbril I had added upstream earlier and just fetched and rebased it but there appears to be no change.
I also did that before pushing changes to my own repo.

@nitishp25 nitishp25 force-pushed the remove-parallel-from-full branch from 4bc5591 to eff42cf Compare January 14, 2020 15:32
@nitishp25
Copy link
Contributor Author

Please review now @OriolAbril

@OriolAbril OriolAbril merged commit 5daff6a into arviz-devs:master Jan 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove parallel from arviz.utils.full?
2 participants