[fix] [broker] correct compaction phase one timeout meaning (apache#2…

…1908) Correct the description of the config `brokerServiceCompactionPhaseOneLoopTimeInSeconds`
ascentstream · Jan 22, 2024 · 3fa85f0 · 3fa85f0
1 parent 5a65e98
commit 3fa85f0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/conf/broker.conf b/conf/broker.conf
@@ -534,8 +534,8 @@ brokerServiceCompactionMonitorIntervalInSeconds=60
 # Using a value of 0, is disabling compression check.
 brokerServiceCompactionThresholdInBytes=0
 
-# Timeout for the compaction phase one loop.
-# If the execution time of the compaction phase one loop exceeds this time, the compaction will not proceed.
+# Timeout for each read request in the compaction phase one loop.
+# If the execution time of one single message read operation exceeds this time, the compaction will not proceed.
 brokerServiceCompactionPhaseOneLoopTimeInSeconds=30
 
 # Whether retain null-key message during topic compaction

diff --git a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
@@ -2803,8 +2803,8 @@ The delayed message index time step(in seconds) in per bucket snapshot segment,
 
     @FieldContext(
             category = CATEGORY_SERVER,
-            doc = "Timeout for the compaction phase one loop, If the execution time of the compaction "
-                    + "phase one loop exceeds this time, the compaction will not proceed."
+            doc = "Timeout for each read request in the compaction phase one loop, If the execution time of one "
+                    + "single message read operation exceeds this time, the compaction will not proceed."
     )
     private long brokerServiceCompactionPhaseOneLoopTimeInSeconds = 30;